Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module): add default to module exports #56

Merged
merged 1 commit into from
Sep 14, 2024
Merged

fix(module): add default to module exports #56

merged 1 commit into from
Sep 14, 2024

Conversation

LucaDiba
Copy link
Contributor

This fixes issue #55.

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@andris9 andris9 merged commit 4f99ebe into postalsys:master Sep 14, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Sep 14, 2024
Merged
@RiskyMH
Copy link

RiskyMH commented Sep 16, 2024 •
edited
Loading

@LucaDiba @andris9 btw this has broken my app with webpack and next.js:

./app/api/v0/route.ts
Module not found: Default condition should be last one

@andris9
Copy link
Contributor

andris9 commented Sep 16, 2024

@RiskyMH I moved the default exports to the last position in [email protected]. Could you try to upgrade to see if it fixes your issue?

@RiskyMH
Copy link

RiskyMH commented Sep 16, 2024 •
edited
Loading

@RiskyMH I moved the default exports to the last position in [email protected]. Could you try to upgrade to see if it fixes your issue?

Yay thanks, this works now!
also thanks for this lib as it really has helped me with my projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LucaDiba @CLAassistant @RiskyMH @andris9